Lunderberg opened a new pull request, #14494: URL: https://github.com/apache/tvm/pull/14494
Prior to this commit, `PrimFuncPass` directly removed empty `PrimFunc` objects from the module's `Map<GlobalVar, BaseFunc> functions`. Because it didn't update the `global_var_map_` as well, these two maps could become out of sync. Since the `global_var_map_` is checked as part of `StructuralEqual()`, but isn't displayed when printing to TVMScript, this can result in identical printouts being flagged as non-identical. This commit updates `PrimFuncPass` to call the `IRModuleNode::Remove` method, which updates both the `functions` and `global_var_map_` variables. This is part of changes described in https://github.com/apache/tvm/pull/14486, to improve round-trip failures that occur in lowering. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
