masahi commented on code in PR #14343:
URL: https://github.com/apache/tvm/pull/14343#discussion_r1157680159
##########
python/tvm/topi/vision/ssd/multibox.py:
##########
@@ -230,9 +242,9 @@ def hybrid_multibox_transform_loc(cls_prob, loc_pred,
anchor, clip, threshold, v
out_loc[i, valid_count[i], 0] = cls_id - 1.0
out_loc[i, valid_count[i], 1] = score
for l in range(4):
- box_coord[l] = anchor[0, j, l]
- pred_coord[l] = loc_pred[i, j * 4 + l]
- out_coord = _hybridy_transform_loc(box_coord, pred_coord,
variances, clip)
+ box_coord[i, l] = anchor[0, j, l]
Review Comment:
It seems `box_coord` is the same in all threads. How about passing `anchor`,
`j`, and `l` to `_hybridy_transform_loc` instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]