driazati commented on code in PR #14477:
URL: https://github.com/apache/tvm/pull/14477#discussion_r1159031920
##########
ci/jenkins/templates/utils/macros.j2:
##########
@@ -31,9 +31,12 @@ sh(
{% for shard_index in range(1, num_shards + 1) %}
{% set method_name = "shard_run_" + name.replace(":", "").replace(" ",
"-").replace("-", "_") + "_" + shard_index|string + "_of_" + num_shards|string
%}
{% set test_dir_name = name.replace(":", "").replace(" ", "-").replace("-",
"_")|string %}
-def {{ method_name }}() {
+def {{ method_name }}(node_type='{{ node }}-SPOT', on_demand=false) {
Review Comment:
Any of the spot/on-demand should stay within Jinja2 (so everything is
hardcoded in the Jenkinsfiles), we should keep `node_type` inside of Jinja (see
the `{% set ... %}` blocks above) rather than as a groovy variable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
