kparzysz-quic commented on code in PR #14488: URL: https://github.com/apache/tvm/pull/14488#discussion_r1159871618
########## include/tvm/script/ir_builder/tir/ir.h: ########## @@ -428,16 +428,26 @@ void Evaluate(PrimExpr value); /*! * \brief Create a TIR var that represents a pointer + * * \param dtype The data type of the pointer. + * * \param storage_scope The storage scope of the pointer. + * * \param is_size_var Whether the pointer is a size var. + * + * \param is_unknown_type Used to distinguish between + * `PrimType(DataType::Handle())` and + * `PointerType(PrimType(DataType::Void()))`. If true, resolve dtype + * of `Void()` as `PrimType`, and if false resolve dtype of `Void()` Review Comment: `Void` is defined as `DataType(kHandle, 0, 0)`, while a legitimate handle has non-zero bits and lanes. Do we need an additional parameter here instead of passing the right thing in `dtype`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
