echuraev commented on code in PR #14519:
URL: https://github.com/apache/tvm/pull/14519#discussion_r1160498256
##########
python/tvm/topi/arm_cpu/depthwise_conv2d.py:
##########
@@ -394,7 +394,8 @@ def schedule_conv_out(out):
ci_outer, ci_inner = s[out].split(ci, 4)
s[out].vectorize(ci_inner)
s[out].unroll(ci_outer)
-
+ else:
+ s[out].vectorize(ci)
Review Comment:
Thank you for your answer. I think that to avoid guesses about the size of
`ci` (are use sure that it will be equal to `8`?) you can just add a filter
parameter to define split, e.g.:
```python
cfg.define_split("tile_c", c, num_outputs=2, filter=lambda entry:
entry.size[1] <= 32)
```
In this case I believe we can guarantee that `ci` won't be bigger than 32.
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
