tqchen commented on code in PR #14521:
URL: https://github.com/apache/tvm/pull/14521#discussion_r1160714232
##########
src/topi/einsum.cc:
##########
@@ -98,24 +98,33 @@ EinsumEquation EinsumEquation::FromString(const
std::string& equation) {
}
PrimExpr GetBroadcastedExtent(const PrimExpr& extent1, const PrimExpr&
extent2) {
- int64_t extent1_value = GetConstInt(extent1);
- int64_t extent2_value = GetConstInt(extent2);
- if (extent1_value == extent2_value) {
+ const IntImmNode* extent1_imm = extent1.as<IntImmNode>();
Review Comment:
One minor note for future, would be useful to have common broadcast extent
handling in the future
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
