cbalint13 commented on code in PR #14468:
URL: https://github.com/apache/tvm/pull/14468#discussion_r1161596806
##########
vta/scripts/tune_resnet.py:
##########
@@ -184,7 +184,7 @@ def tune_tasks(
# create tuner
if tuner == "xgb" or tuner == "xgb-rank":
Review Comment:
@FrozenGene ,
Uptade
> @FrozenGene
>
> > `tuner == "xgb-rank"` should be changed too.
>
> Thanks for the observation !
>
> * fixed and exposed properly all such cases.
> * exposed / updated tmvc with extended options coverage.
> * extended the demo lists (taken from original `tune_relay_arm.py` for
completeness)
Plus:
* leaved "rank" types in the list for compatibility with xgboost < 2.0.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
