tqchen commented on PR #14571: URL: https://github.com/apache/tvm/pull/14571#issuecomment-1503457940
Update: We also removed the rule that simplifies (x + 1) % 2 => 1 - x % 2 as benefit is minimal and it introduces extra negative cooefficients that hurts analysis in general (as negative coefficients are harder in many cases). Another take away: we should avoid putting too much burdens on rewrite simplify, some of the examples(that covers long range dependencies) can be better covered by canonical as a result do not need to goto rewrite. Let us check the cases under broader simplifier before adding a new rule for long range dep -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
