yzh119 commented on code in PR #14502:
URL: https://github.com/apache/tvm/pull/14502#discussion_r1167362340
##########
src/tir/schedule/primitive/compute_inline.cc:
##########
@@ -295,7 +295,8 @@ class BaseInliner : public StmtExprMutator {
* \param stmt The statement in which to count undefined variables
*/
static int GetNumUndefinedNonpointerVars(const Stmt& stmt) {
- auto undefined_vars = UndefinedVars(stmt, {});
+ // Do not visit buffer shape/strides.
+ auto undefined_vars = UndefinedVars(/*stmt=*/stmt, /*defs=*/{},
/*visit_buffer=*/false);
Review Comment:
Hi @Lunderberg sorry for being late, would you mind helping review #14451
instead? The `GetNumUndefinedNonpointerVars ` check doesn't seem to work on
nested blocks (in dynamic workloads we always blockize the dynamic loop, which
would emit nested blocks). So I prefer moving on with the solution in #14451
which uses a simpler check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
