tqchen commented on code in PR #14690:
URL: https://github.com/apache/tvm/pull/14690#discussion_r1173718510
##########
src/node/reflection.cc:
##########
@@ -32,57 +32,6 @@ using runtime::PackedFunc;
using runtime::TVMArgs;
using runtime::TVMRetValue;
-// Attr getter.
-class AttrGetter : public AttrVisitor {
- public:
- const String& skey;
- TVMRetValue* ret;
-
- AttrGetter(const String& skey, TVMRetValue* ret) : skey(skey), ret(ret) {}
-
- bool found_ref_object{false};
-
- void Visit(const char* key, double* value) final {
- if (skey == key) *ret = value[0];
- }
- void Visit(const char* key, int64_t* value) final {
- if (skey == key) *ret = value[0];
- }
- void Visit(const char* key, uint64_t* value) final {
- ICHECK_LE(value[0],
static_cast<uint64_t>(std::numeric_limits<int64_t>::max()))
- << "cannot return too big constant";
- if (skey == key) *ret = static_cast<int64_t>(value[0]);
- }
- void Visit(const char* key, int* value) final {
- if (skey == key) *ret = static_cast<int64_t>(value[0]);
- }
- void Visit(const char* key, bool* value) final {
- if (skey == key) *ret = static_cast<int64_t>(value[0]);
- }
- void Visit(const char* key, void** value) final {
- if (skey == key) *ret = static_cast<void*>(value[0]);
- }
- void Visit(const char* key, DataType* value) final {
- if (skey == key) *ret = value[0];
- }
- void Visit(const char* key, std::string* value) final {
- if (skey == key) *ret = value[0];
- }
-
- void Visit(const char* key, runtime::NDArray* value) final {
- if (skey == key) {
- *ret = value[0];
- found_ref_object = true;
- }
- }
- void Visit(const char* key, runtime::ObjectRef* value) final {
- if (skey == key) {
- *ret = value[0];
- found_ref_object = true;
- }
Review Comment:
looks like unintentional change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
