yzh119 commented on code in PR #14695:
URL: https://github.com/apache/tvm/pull/14695#discussion_r1174255674
##########
src/target/source/codegen_cuda.cc:
##########
@@ -87,6 +99,7 @@ void CodeGenCUDA::PrintExtraAttrs(const PrimFunc& f) {
}
stream << " __launch_bounds__(" << threadIdx_ext_int->value << ")";
}
+ stream << "\n// intended to be called with\n// dim3 block(" <<
extractor.threadIdx_x_ext << ", " << extractor.threadIdx_y_ext << ", " <<
extractor.threadIdx_z_ext << ");\n// dim3 grid(" << extractor.blockIdx_x_ext <<
", " << extractor.blockIdx_y_ext << ", " << extractor.blockIdx_z_ext << ");\n";
Review Comment:
Please format the code with clang-format, other parts LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
