junrushao commented on code in PR #14812:
URL: https://github.com/apache/tvm/pull/14812#discussion_r1189071460


##########
python/tvm/ir/memory_pools.py:
##########
@@ -245,7 +245,7 @@ def __init__(
         )
 
 
-@register_object("ir.ConstantMemoryPools")

Review Comment:
   A bit off the topic, but to some extent, I believe it might be less ideal if 
we expose those feature-dependent component in `tvm/ir` folder, which is 
supposed to be generic. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to