tqchen commented on code in PR #14394:
URL: https://github.com/apache/tvm/pull/14394#discussion_r1196918248
##########
include/tvm/relax/expr.h:
##########
@@ -920,10 +920,16 @@ class FunctionNode : public BaseFuncNode {
Expr body;
/*! \brief The return type of the function. */
StructInfo ret_struct_info;
+ /*! \brief Whether the function is annotated as pure or not. */
+ bool is_pure;
Review Comment:
right, would be good to keep force_pure as an attr.
interesting, didn't think about that issue(optional argument while having
R.function without explicit argument), perhaps allowing also a default for
R.function can work. We can do that as a followup
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]