quic-sanirudh commented on code in PR #14879:
URL: https://github.com/apache/tvm/pull/14879#discussion_r1197943774
##########
src/target/llvm/codegen_cpu.cc:
##########
@@ -466,13 +466,14 @@ llvm::Value* CodeGenCPU::CreateCallExtern(Type ret_type,
String global_symbol,
llvm::FunctionType* ftype = llvm::FunctionType::get(GetLLVMType(ret_type),
arg_types, false);
// Check if it is available in global function table as injected function.
+ llvm::Function* f = module_->getFunction(MakeStringRef(global_symbol));
auto callee = [&]() -> llvm::Value* {
Review Comment:
`callee` is only used when `#if TVM_LLVM_VERSION >= 90` is true. So, could
we just move the whole `callee` initialization lambda into that branch of the
conditional directive?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
