Lunderberg commented on code in PR #14879: URL: https://github.com/apache/tvm/pull/14879#discussion_r1197959441
########## src/target/llvm/codegen_cpu.cc: ########## @@ -466,13 +466,14 @@ llvm::Value* CodeGenCPU::CreateCallExtern(Type ret_type, String global_symbol, llvm::FunctionType* ftype = llvm::FunctionType::get(GetLLVMType(ret_type), arg_types, false); // Check if it is available in global function table as injected function. + llvm::Function* f = module_->getFunction(MakeStringRef(global_symbol)); Review Comment: Instead of exposing `llvm::Function* f` outside the scope, could we instead replace `auto ext_callee = f;` on line 490 with `auto ext_callee = callee;`? The current change would allow compilation, but would skip the optional pointer-cast of the callee. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
