echuraev commented on code in PR #14885:
URL: https://github.com/apache/tvm/pull/14885#discussion_r1199409048
##########
tests/python/frontend/pytorch/test_forward.py:
##########
@@ -4798,6 +4798,7 @@ def test_forward_l1_loss():
verify_model(torch.nn.L1Loss().eval(), input_data=[predictions, targets])
verify_model(torch.nn.L1Loss(reduction="sum").eval(),
input_data=[predictions, targets])
verify_model(torch.nn.L1Loss(reduction="none").eval(),
input_data=[predictions, targets])
+ verify_model(torch.nn.L1Loss().eval(), input_data=[predictions, targets])
Review Comment:
It looks like the same test exists two lines above. If there is no any other
way to test this change then I agree with @shingjan that the added tests can be
removed and just the comment will be enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
