echuraev commented on code in PR #14930:
URL: https://github.com/apache/tvm/pull/14930#discussion_r1203819166
##########
tests/python/frontend/pytorch/test_forward.py:
##########
@@ -578,9 +578,15 @@ class Squeeze2(Module):
def forward(self, *args):
return args[0].squeeze(1)
+ class Squeeze3(Module):
+ def forward(self, *args):
+ return args[0].squeeze((1, 3))
Review Comment:
Probably this code can be modified and all these classes can be squeezed
into one class. This one class will take the arguments for squeeze.
##########
tests/python/frontend/pytorch/test_forward.py:
##########
@@ -578,9 +578,15 @@ class Squeeze2(Module):
def forward(self, *args):
return args[0].squeeze(1)
+ class Squeeze3(Module):
+ def forward(self, *args):
+ return args[0].squeeze((1, 3))
+
input_data = torch.rand(input_shape).float()
verify_model(Squeeze1().float().eval(), input_data=input_data)
verify_model(Squeeze2().float().eval(), input_data=input_data)
+ if package_version.parse(torch.__version__) >=
package_version.parse("2.0.0"):
Review Comment:
Why did you add this check on torch version?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
