This is an automated email from the ASF dual-hosted git repository.
tqchen pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tvm.git
The following commit(s) were added to refs/heads/main by this push:
new 227c4e87f3 [CI] Update the expected CI jobs list in the update_branch
script (#14908)
227c4e87f3 is described below
commit 227c4e87f3c2cc2fdc33759b6e15cf9f51cde4fe
Author: Florin Blanaru <[email protected]>
AuthorDate: Sat May 27 00:33:06 2023 +0300
[CI] Update the expected CI jobs list in the update_branch script (#14908)
---
ci/scripts/github/update_branch.py | 19 +++++++++++++--
tests/python/ci/test_ci.py | 49 +++++++++++++-------------------------
2 files changed, 33 insertions(+), 35 deletions(-)
diff --git a/ci/scripts/github/update_branch.py
b/ci/scripts/github/update_branch.py
index 9f689f6bfa..e49d9e47ab 100755
--- a/ci/scripts/github/update_branch.py
+++ b/ci/scripts/github/update_branch.py
@@ -87,6 +87,22 @@ def commits_query(user: str, repo: str, cursor: str = None):
"""
+EXPECTED_CI_JOBS = [
+ "cross-isa-minimal/branch",
+ "gpu/branch",
+ "hexagon/branch",
+ "arm/branch",
+ "cortexm/branch",
+ "cpu/branch",
+ "docker/branch",
+ "i386/branch",
+ "lint/branch",
+ "minimal/branch",
+ "riscv/branch",
+ "wasm/branch",
+]
+
+
def commit_passed_ci(commit: Dict[str, Any]) -> bool:
"""
Returns true if all of a commit's statuses are SUCCESS
@@ -111,9 +127,8 @@ def commit_passed_ci(commit: Dict[str, Any]) -> bool:
# Assert that specific jobs are present in the commit statuses (i.e. don't
# approve if CI was broken and didn't schedule a job)
- expected_jobs = {"tvm-ci/branch"}
job_names = {name for name, status in unified_statuses}
- for job in expected_jobs:
+ for job in EXPECTED_CI_JOBS:
if job not in job_names:
# Did not find expected job name
return False
diff --git a/tests/python/ci/test_ci.py b/tests/python/ci/test_ci.py
index f83fa40c61..ca749665c9 100644
--- a/tests/python/ci/test_ci.py
+++ b/tests/python/ci/test_ci.py
@@ -36,6 +36,8 @@ sys.path.insert(0, str(GITHUB_SCRIPT_ROOT))
import scripts.github
import scripts.jenkins
+from scripts.github.update_branch import EXPECTED_CI_JOBS
+
# pylint: enable=wrong-import-position,wrong-import-order
@@ -434,8 +436,12 @@ def test_cc_reviewers(
assert f"After filtering existing reviewers, adding: {expected_reviewers}"
in proc.stdout
+def generate_good_commit_status():
+ return list([{"context": context, "state": "SUCCESS"} for context in
EXPECTED_CI_JOBS])
+
+
@parameterize_named(
- # Missing expected tvm-ci/branch test
+ # Missing expected gpu/branch test
missing_tvm_ci_branch=dict(
statuses=[
{
@@ -448,48 +454,25 @@ def test_cc_reviewers(
),
# Only has the right passing test
has_expected_test=dict(
- statuses=[
- {
- "context": "tvm-ci/branch",
- "state": "SUCCESS",
- }
- ],
+ statuses=generate_good_commit_status(),
expected_rc=0,
expected_output="Found last good commit: 123: hello",
),
# Check with many statuses
many_statuses=dict(
- statuses=[
- {
- "context": "tvm-ci/branch",
- "state": "SUCCESS",
- },
- {
- "context": "tvm-ci/branch2",
- "state": "SUCCESS",
- },
- {
- "context": "tvm-ci/branch3",
- "state": "FAILED",
- },
+ statuses=generate_good_commit_status()
+ + [
+ {"context": "gpu/branch2", "state": "SUCCESS"},
+ {"context": "gpu/branch3", "state": "FAILED"},
],
expected_rc=1,
expected_output="No good commits found in the last 1 commits",
),
many_success_statuses=dict(
- statuses=[
- {
- "context": "tvm-ci/branch",
- "state": "SUCCESS",
- },
- {
- "context": "tvm-ci/branch2",
- "state": "SUCCESS",
- },
- {
- "context": "tvm-ci/branch3",
- "state": "SUCCESS",
- },
+ statuses=generate_good_commit_status()
+ + [
+ {"context": "gpu/branch2", "state": "SUCCESS"},
+ {"context": "gpu/branch3", "state": "SUCCESS"},
],
expected_rc=0,
expected_output="Found last good commit: 123: hello",
