echuraev commented on code in PR #14972:
URL: https://github.com/apache/tvm/pull/14972#discussion_r1209333671
##########
tests/python/unittest/test_target_codegen_opencl.py:
##########
@@ -150,50 +158,38 @@ def check_type_casting(ctx, n, dtype):
tvm.tir.all(
*[
i // block_size == tvm.tir.const(3, "int32"),
- i % block_size == tvm.tir.const(3, "int32"),
Review Comment:
> so the original condition get simplified and becomes i == 15 here
Do you mean that this condition:
```
tvm.tir.all(
*[
i // block_size == tvm.tir.const(3, "int32"),
i % block_size == tvm.tir.const(3, "int32"),
]
),
```
Was transformed to `i == 15`?
##########
tests/python/unittest/test_target_codegen_opencl.py:
##########
@@ -150,50 +158,38 @@ def check_type_casting(ctx, n, dtype):
tvm.tir.all(
*[
i // block_size == tvm.tir.const(3, "int32"),
- i % block_size == tvm.tir.const(3, "int32"),
Review Comment:
I took a look at the git history and the original problem which should be
covered by this test was that left and right parts of condition should have the
same data type. You can see detailed description in #11021. And next this test
was added in #11038.
By decreasing the number of conditions in `tvm.tir.all`, you prevent
compiler to generate code such as `lcond && rcond`. Am I right? In this case,
the original problem won't be tested. Sorry if I missed something.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
