FranklandJack commented on code in PR #14981:
URL: https://github.com/apache/tvm/pull/14981#discussion_r1213102123
##########
src/target/target_kind.cc:
##########
@@ -257,6 +257,12 @@ TargetJSON TestTargetParser(TargetJSON target) {
/********** Register Target kinds and attributes **********/
+#if defined(__arm__) || defined(__aarch64__)
+#define NATIVE_CPU "arm_cpu"
+#else
+#define NATIVE_CPU "cpu"
+#endif
Review Comment:
A general solution would definitely be preferable, do you have a suggestion
of how one would use the target parser to do this?
Since we've gone from being x86 specfic to arm and x86 specfic I'd argue
this is still an improvement over what we had before. We can always add support
for more targets in future PRs.
It's worth noting that this has exposed a lot of false positive tests on the
`arm_cpu` target, if the same thing happens for other targets it might be
advantageous to do this iteratively in order to keep the diff contained.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
