Aleksei-grovety commented on code in PR #14994:
URL: https://github.com/apache/tvm/pull/14994#discussion_r1214112117
##########
python/tvm/driver/tvmc/compiler.py:
##########
@@ -572,22 +572,26 @@ def annotate_f(x):
# to the Relay, in which case we can not associate the initial
Relay string
# with the resulting Relay call
source_name = x.span.source_name.name
- if source_name in operations_distribution:
- compiler_name, op_name, func_id =
operations_distribution[source_name]
+ result = re.search(r"(.*)(_PART_)(.*)", source_name)
Review Comment:
Maybe instead of string "_PART_", use field suffix of the _SuffixTagger
class where this string is defined.
##########
python/tvm/driver/tvmc/compiler.py:
##########
@@ -598,13 +602,13 @@ def annotate_f(x):
# funcs_dict is a mapping of the generated
analyze_operations_distribution
# internal composite/function IDs to a list, where:
# 1st element is
- # (1a): target name - it could be "generic" or "unknown" or
Review Comment:
Maybe add a description of what is meant by generic, unknown, none
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
