Lunderberg opened a new pull request, #15073:
URL: https://github.com/apache/tvm/pull/15073

   Prior to this PR, the return type for `CodeGenC` was hard-coded as part of 
`virtual CodeGenC::PrintFuncPrefix`, regardless of the return type specified in 
the `PrimFunc`.  This PR updates `CodeGenC` to use `PrimFuncNode::ret_type` for 
the return type in the generated C code.
   
   This change should have no effect on observable behavior, while allowing the 
forward declaration of external functions to be improved.  The majority of 
codegen classes specified a `void` return type, which matches the default 
`DataType::Void()` for a `PrimFunc`.  The one exception is 
`CodeGenCHost::PrintFuncPrefix`, which specified an `int32_t` return type, 
matching the `DataType::Int(32)` used for the functions generated by 
`MakePackedAPI` and `MakeUnpackedAPI`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to