srkreddy1238 commented on code in PR #15058:
URL: https://github.com/apache/tvm/pull/15058#discussion_r1228985842
##########
src/runtime/cuda/cuda_device_api.cc:
##########
@@ -105,6 +105,8 @@ class CUDADeviceAPI final : public DeviceAPI {
}
case kDriverVersion:
return;
+ default:
Review Comment:
We could do that. But, I see the DeviceAttrKind is getting too diversified
and not every target implements/supports all of them. I thought default avoids
adding this case for all targets everytime.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
