Lunderberg commented on PR #15102: URL: https://github.com/apache/tvm/pull/15102#issuecomment-1591673785
Thank you @tqchen, and this change makes sense, and would prevent any later use of `BindTarget` from adding an erroneous host. I assume that this is needed for compatibility in the unity branch? (Trying to think of functionality tests that could be added on the main branch to validate this behavior.) Regarding `MakePackedAPI`, I think the main issue is that `MakePackedAPI` needs to know both the host, so that the resulting device function can have the same host as is used by other functions in the module, and needs the device so that the correct device type can be checked in `ArgBinder::BindDLTensor`. I've been thinking about whether `tir::Buffer` could have an optional parameter for the device type, which could be populated during `SplitHostDevice` to provide the device type for `MakePackedAPI` to use. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
