masahi commented on code in PR #15111: URL: https://github.com/apache/tvm/pull/15111#discussion_r1232880648
########## src/runtime/contrib/cutlass/weight_preprocess.cc: ########## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +#include <tvm/runtime/ndarray.h> +#include <tvm/runtime/packed_func.h> +#include <tvm/runtime/registry.h> + +#include "../../../3rdparty/cutlass_fpA_intB_gemm/cutlass_kernels/cutlass_preprocessors.h" + +namespace tvm { +namespace runtime { + +TVM_REGISTER_GLOBAL("cutlass.ft_preprocess_weight_int4") + .set_body_typed([](NDArray packed_weight, int sm) { + int rows = packed_weight->shape[0]; + int cols = packed_weight->shape[1]; + std::vector<int8_t> input_cpu(rows * cols); + std::vector<int8_t> output_cpu(rows * cols); + packed_weight.CopyToBytes(input_cpu.data(), input_cpu.size()); + // multiply cols by 2 since the "col" params in preprocess_weights refers to the column of + // the unpacked weight. + fastertransformer::preprocess_weights(output_cpu.data(), input_cpu.data(), rows, cols * 2, Review Comment: Note that this function is meant to be run at compile time. It needs to run on CPU since the preprocess functions are defined by FT in C++. I don't find them to be slow, so given the amount of effort required by GPU porting, I don't think it's worth it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
