echuraev commented on code in PR #15121: URL: https://github.com/apache/tvm/pull/15121#discussion_r1236398167
########## tests/python/contrib/test_reshape_0_copy.py: ########## Review Comment: IMHO, I would say that better use `zero` instead of `0` in the name of the file, e.g `test_reshape_zero_copy.py`. Also, probably you can move this test to the [file](https://github.com/apache/tvm/blob/main/tests/python/unittest/test_runtime_module_based_interface.py#L693) with existing tests on zero_copy. ########## src/runtime/graph_executor/graph_executor.cc: ########## @@ -566,7 +588,7 @@ std::pair<std::function<void()>, std::shared_ptr<GraphExecutor::OpArgs>> GraphEx } if (param.func_name == "__nop") { - return {[]() {}, arg_ptr}; + return {[arg_ptr]() {}, arg_ptr}; Review Comment: What is the reason of capturing `arg_ptr` in empty lambda? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
