Lunderberg opened a new pull request, #15136:
URL: https://github.com/apache/tvm/pull/15136

   Prior to this commit, the tests in 
`test_tir_transform_inject_ptx_async_copy.py` registered the 
`"tvm_callback_cuda_postproc"` function during pytest collection, and used a 
global variable to disable its functionality outside of the tests in this file. 
 This had two major issues.  First, if any other test also installs a postproc 
function, these postproc function required by the NVPTX tests would be 
overwritten.  Second, if one of the NTPTX tests fails, the global variable 
controlling the postproc function would not be reset, causing any subsequent 
CUDA-related tests to also fail.
   
   This commit updates these NVPTX tests to conditionally install the postproc 
function, to de-register it after the test instead of disabling its 
functionality, and to de-register it regardless of the test result.
   
   This issue was initially found when debugging 
https://github.com/apache/tvm/pull/15103, when a failure in 
`test_tir_transform_inject_ptx_async_copy.py::test_cp_async_in_if_then_else` 
caused failures in 32 unrelated tests ([CI 
link](https://ci.tlcpack.ai/blue/organizations/jenkins/tvm-gpu/detail/PR-15103/7/tests)).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to