slyubomirsky commented on code in PR #15140:
URL: https://github.com/apache/tvm/pull/15140#discussion_r1237776330
##########
src/relax/transform/lift_transform_params.cc:
##########
@@ -251,7 +251,10 @@ class TransformParamsLifter : public ExprMutator {
lift_plan_ = planner.Plan(func, num_input);
// Step 2: Add the lifted function to the module
- builder_->AddFunction(lift_plan_.f_transform_params, new_func_name);
+ // (The lifted function should be public so we add a global symbol to it)
Review Comment:
I am assuming we want them to be public.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
