tqchen commented on code in PR #15142:
URL: https://github.com/apache/tvm/pull/15142#discussion_r1240770500
##########
tests/python/unittest/test_tir_schedule_compute_inline.py:
##########
@@ -622,8 +621,8 @@ def elementwise_overcomputed_producer_reverse_inlined(
for i, j in T.grid(128, 128):
with T.block("B"):
vi, vj = T.axis.remap("SS", [i, j])
- T.where(i < 127 and j < 127)
- C[vi, vj] = A[vi, vj] * 2.0 + 1.0
+ if vi < 127 and vj < 127:
Review Comment:
We had some discussions on this topic. T.where is a mechanism to use to
handle the iterator predicate outside the block. We had a restriction that the
affine map indicated by T.where plus the axis binding must match the loop
domain declared.
In the specific case of reverse compute inline with over relaxing part, we
are not exactly changing the loop domain, but change the internal operations,
since we are iterating over the loops and would like to skip some operations.
So having if here is better and matches the design of block isolation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
