tqchen commented on code in PR #15161:
URL: https://github.com/apache/tvm/pull/15161#discussion_r1243749893
##########
include/tvm/runtime/logging.h:
##########
@@ -367,11 +367,7 @@ class LogFatal {
this->lineno_ = lineno;
}
[[noreturn]] TVM_NO_INLINE dmlc::Error Finalize() {
- InternalError error(file_, lineno_, stream_.str());
-#if DMLC_LOG_BEFORE_THROW
Review Comment:
keep LOG_BEFORE_THROW guard as it is useful for windows
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
