tqchen commented on code in PR #15140:
URL: https://github.com/apache/tvm/pull/15140#discussion_r1244434012
##########
tests/python/relax/test_transform_merge_composite_functions.py:
##########
@@ -41,7 +41,7 @@ def main(
R.output(gv)
return gv
- @R.function
+ @R.function(private=True)
Review Comment:
I think by default fusion pass should not produce functions with global
symbol. Ideally we should prevent fusing functions that with global symbol ---
because user expects to access the original function
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
