LeiWang1999 commented on code in PR #15106: URL: https://github.com/apache/tvm/pull/15106#discussion_r1244906575
########## python/tvm/tir/tensor_intrin/rocm.py: ########## @@ -20,6 +20,11 @@ from .. import TensorIntrin from .dot_product_common import dp4a_desc +from tvm.runtime import convert +from tvm.tir.expr import Cast, IntImm +from tvm.tir.function import TensorIntrin + +lift = convert Review Comment: sure, I'm sorry that I didn't see the conversation, I think this alias can be deleted, given this pr has been merged and I will be introducing some new features later on, like other data layouts, and we can address the issue when we do that, mark.. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
