ekalda commented on PR #15117: URL: https://github.com/apache/tvm/pull/15117#issuecomment-1612984334
Thanks for the patch @ilyag-grovety, looks all very neat and good to me. Hopefully the CI will go green as well once the model URL will be properly enabled. Regarding to testing, from my research, I didn't find a way to create that operator through current TF or Keras APIs either, so I think using the model consisting of this operator is the best approach here. I think using simple sorting algorithm is fine for now. I don't know what it would take to enable `argsort` for `cpp` runtime, but any effort of that kind should be a separate patch anyway. If bubble sort becomes a massive performance bottleneck in the future, then it is possible to further enhance this operator with enabling `argsort` or implementing a different sorting algorithm, but for now it should be fine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
