srkreddy1238 commented on PR #15058: URL: https://github.com/apache/tvm/pull/15058#issuecomment-1637465101
@tqchen I enhanced to reuse the existing VM runtime memory manager by graph executor at https://github.com/apache/tvm/pull/15058/commits/31d7de0cb6ee6dc0d1efcc8d53f2e570af7316f0 Basically, - Promoted memory manager from ```runtime/vm``` to ``runtime`` level - Redirected graph executor to use Memory Manager interface for StorageSetup. - Corresponding changes in OpenCL Runtime to work with this MemoryManager. Let me know your opinion on these. Another recommendation I have is redirecting ```AllocWorkspace``` and ```FreeWorkspace``` to MemoryManager and drop ```workspace_pool```. ```workspace_pool``` is slightly different from ```pooled_allocator``` (workspace pool looks for best fit where as pooled allocator look for exact fit) and we can amend this functionality. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
