yzh119 commented on code in PR #15340:
URL: https://github.com/apache/tvm/pull/15340#discussion_r1265823417
##########
python/tvm/dlight/gpu/decode_gemv.py:
##########
@@ -220,8 +220,7 @@ def _sch_inner_spatial(
s = sch.fuse(*s)
sch.reorder(s, r)
if unroll_spatial_factor:
- s, inner = sch.split(s, factors=[None, unroll_spatial_factor])
- sch.reorder(s, r, inner)
+ s, _ = sch.split(s, factors=[None, unroll_spatial_factor])
Review Comment:
and this implies the new loop order is `(s, inner, r)` which meets the
requirement of CrossThreadReduction pass :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
