junrushao commented on code in PR #15214: URL: https://github.com/apache/tvm/pull/15214#discussion_r1267141385
########## include/tvm/script/ir_builder/tir/ir.h: ########## @@ -56,7 +56,7 @@ Buffer BufferDecl(Array<PrimExpr> shape, DataType dtype, String buffer_name, Opt * \brief The primitive function statement. * \return The PrimFuncFrame. */ -PrimFuncFrame PrimFunc(); +PrimFuncFrame PrimFunc(const Bool& is_private); Review Comment: let's use `bool` here given we don't need nullability: ```suggestion PrimFuncFrame PrimFunc(bool is_private); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
