zxybazh commented on code in PR #15133:
URL: https://github.com/apache/tvm/pull/15133#discussion_r1272572171
##########
python/tvm/meta_schedule/tir_integration.py:
##########
@@ -58,6 +58,7 @@ def tune_tir( # pylint: disable=too-many-locals
seed: Optional[int] = None,
module_equality: str = "structural",
special_space: Optional[Mapping[str, SpaceGenerator.SpaceGeneratorType]] =
None,
+ **kwargs,
Review Comment:
Hi Vincent, thanks for the explanation, it makes sense to me that
`set_tree_method` only work for xgb model and we shouldn't specialize it for
all the cost models. On the other hand, the `**kwargs` here is used in a
`tune_tir` api and it would be a bit hard to figure out if certain argument is
given for cost model or database, or even other classes. Another issue is when
multiple class use the same argument, it would be hard to handle. IMHO we may
try to let the users configure cost model separately and call in the `tune_tir`
api as follows:
```python
cost_model = CostModel.create("xgb", num_tuning_cores=num_cores, tree_method
= "auto")
tune_tir(mod, ..., cost_model=cost_model)
```
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
