sunggg commented on code in PR #15466:
URL: https://github.com/apache/tvm/pull/15466#discussion_r1283308231
##########
python/tvm/dlight/benchmark/utils.py:
##########
@@ -101,7 +106,11 @@ def populuate_input_shape(
return results
-def default_dym_var_sample_func(dym_var_dict: Dict[str, str]) -> Dict[str,
int]:
+def default_dym_var_sample_func(
+ dym_var_dict: Dict[str, str],
+ sample_idx: int, # pylint: disable=unused-argument
Review Comment:
Seems like `sample_idx` is not used?
##########
python/tvm/dlight/benchmark/utils.py:
##########
@@ -110,6 +119,11 @@ def default_dym_var_sample_func(dym_var_dict: Dict[str,
str]) -> Dict[str, int]:
----------
dym_var_dict : Dict[str, str]
Dynamic shape variable dictionary, e.g., {"n": "int32", "m": "int32"}
Review Comment:
Is there any case where we express shape values other than "int64"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
