Archermmt commented on PR #15500: URL: https://github.com/apache/tvm/pull/15500#issuecomment-1670407138
> Generally LGTM. One key problem is that how do we test MSC on CI? I add some tests under tests/python/contrib/test_msc. Tests in this folder will cover most of the modules and can be used as test in CI. However, I plan to add these tests to CI after Milestone4, when end to end demos are added and most features are stable. After the e2e demo, I will discuss with the unity on whether MSC should be used as infrastructure for model optimization and how it be further developed. If the design of MSC helps in model optimization and will be developed by other developers, CI tests are necessary. Before that, design and modules may be modified and reconstructed, tests may also be changed accordingly. So I prefer run the tests manually before PR, until the most features are stable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
