Repository: twill Updated Branches: refs/heads/master 3d810d4a2 -> f866b50d7 (forced update)
(TWILL-238) restart instances with Set of Integers This closes #56 on Github. Signed-off-by: Terence Yim <[email protected]> Project: http://git-wip-us.apache.org/repos/asf/twill/repo Commit: http://git-wip-us.apache.org/repos/asf/twill/commit/f866b50d Tree: http://git-wip-us.apache.org/repos/asf/twill/tree/f866b50d Diff: http://git-wip-us.apache.org/repos/asf/twill/diff/f866b50d Branch: refs/heads/master Commit: f866b50d707ae30d79537b5207afb321238f071f Parents: 401496a Author: Sergey Filippov <[email protected]> Authored: Sat Jul 8 14:24:22 2017 +0300 Committer: Terence Yim <[email protected]> Committed: Sun Jul 16 18:21:31 2017 -0700 ---------------------------------------------------------------------- .../java/org/apache/twill/api/TwillController.java | 12 +++++++++++- .../apache/twill/internal/AbstractTwillController.java | 13 +++++++++---- 2 files changed, 20 insertions(+), 5 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/twill/blob/f866b50d/twill-api/src/main/java/org/apache/twill/api/TwillController.java ---------------------------------------------------------------------- diff --git a/twill-api/src/main/java/org/apache/twill/api/TwillController.java b/twill-api/src/main/java/org/apache/twill/api/TwillController.java index f5004ae..10b2b97 100644 --- a/twill-api/src/main/java/org/apache/twill/api/TwillController.java +++ b/twill-api/src/main/java/org/apache/twill/api/TwillController.java @@ -92,6 +92,15 @@ public interface TwillController extends ServiceController { Future<String> restartInstances(String runnable, int instanceId, int... moreInstanceIds); /** + * Restart instances of some {@link TwillRunnable}. + * + * @param runnable The name of the runnable to restart. + * @param instanceIds Instances to be restarted + * @return A {@link Future} that will be completed when the restart operation has been done. + */ + Future<String> restartInstances(String runnable, Set<Integer> instanceIds); + + /** * Update the log levels for requested logger names for Twill applications running in a container. * The log level for a logger name can be {@code null} except for the root logger, which will reset the log level for * the specified logger. @@ -104,7 +113,8 @@ public interface TwillController extends ServiceController { /** * Update the log levels for requested logger names for a {@link TwillRunnable}. - * The log level for a logger name can be {@code null} except for the root logger, which will reset the log level for + * The log level for a logger name can be {@code null} except for the root logger, + * which will reset the log level for * the specified logger. * * @param runnableName The name of the runnable to update the log level. http://git-wip-us.apache.org/repos/asf/twill/blob/f866b50d/twill-core/src/main/java/org/apache/twill/internal/AbstractTwillController.java ---------------------------------------------------------------------- diff --git a/twill-core/src/main/java/org/apache/twill/internal/AbstractTwillController.java b/twill-core/src/main/java/org/apache/twill/internal/AbstractTwillController.java index e49a2ad..fd8a939 100644 --- a/twill-core/src/main/java/org/apache/twill/internal/AbstractTwillController.java +++ b/twill-core/src/main/java/org/apache/twill/internal/AbstractTwillController.java @@ -188,12 +188,17 @@ public abstract class AbstractTwillController extends AbstractZKServiceControlle instanceIds.add(id); } + return restartInstances(runnable, instanceIds); + } + + @Override + public ListenableFuture<String> restartInstances(final String runnable, Set<Integer> instanceIds) { return Futures.transform(restartInstances(ImmutableMap.of(runnable, instanceIds)), new Function<Set<String>, String>() { - public String apply(Set<String> input) { - return runnable; - } - }); + public String apply(Set<String> input) { + return runnable; + } + }); } @Override
