Repository: twill Updated Branches: refs/heads/feature/zk-localhost [created] 01f8123c9
Trying to use loopback address for ZK server Project: http://git-wip-us.apache.org/repos/asf/twill/repo Commit: http://git-wip-us.apache.org/repos/asf/twill/commit/88137f7b Tree: http://git-wip-us.apache.org/repos/asf/twill/tree/88137f7b Diff: http://git-wip-us.apache.org/repos/asf/twill/diff/88137f7b Branch: refs/heads/feature/zk-localhost Commit: 88137f7b28d2ab1d9e201a9dbd8edaf7461f61fe Parents: 8f70aa4 Author: Terence Yim <[email protected]> Authored: Sun Mar 18 15:54:03 2018 -0700 Committer: Terence Yim <[email protected]> Committed: Sun Mar 18 22:22:37 2018 -0700 ---------------------------------------------------------------------- .../internal/zookeeper/InMemoryZKServer.java | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/twill/blob/88137f7b/twill-zookeeper/src/main/java/org/apache/twill/internal/zookeeper/InMemoryZKServer.java ---------------------------------------------------------------------- diff --git a/twill-zookeeper/src/main/java/org/apache/twill/internal/zookeeper/InMemoryZKServer.java b/twill-zookeeper/src/main/java/org/apache/twill/internal/zookeeper/InMemoryZKServer.java index f962b68..ce46808 100644 --- a/twill-zookeeper/src/main/java/org/apache/twill/internal/zookeeper/InMemoryZKServer.java +++ b/twill-zookeeper/src/main/java/org/apache/twill/internal/zookeeper/InMemoryZKServer.java @@ -103,18 +103,18 @@ public final class InMemoryZKServer implements Service { } private InetSocketAddress getAddress(int port) { - try { +// try { int socketPort = port < 0 ? 0 : port; // This property is needed so that in certain CI environment (e.g. Travis-CI) it can only works properly if // it is binded to the wildcard (0.0.0.0) address - if (Boolean.parseBoolean(System.getProperties().getProperty("twill.zk.server.localhost", "true"))) { - return new InetSocketAddress(InetAddress.getLocalHost(), socketPort); - } else { - return new InetSocketAddress(socketPort); - } - } catch (UnknownHostException e) { - throw Throwables.propagate(e); - } +// if (Boolean.parseBoolean(System.getProperties().getProperty("twill.zk.server.localhost", "true"))) { + return new InetSocketAddress(InetAddress.getLoopbackAddress(), socketPort); +// } else { +// return new InetSocketAddress(socketPort); +// } +// } catch (UnknownHostException e) { +// throw Throwables.propagate(e); +// } } private void cleanDir(File dir) {
