Author: degenaro
Date: Fri Jun 3 13:30:39 2016
New Revision: 1746716
URL: http://svn.apache.org/viewvc?rev=1746716&view=rev
Log:
UIMA-4956 DUCC Job Driver(JD) should warn in JD log when negative performance
numbers are encountered
Modified:
uima/sandbox/uima-ducc/trunk/uima-ducc-container/src/main/java/org/apache/uima/ducc/container/jd/fsm/wi/ActionEnd.java
uima/sandbox/uima-ducc/trunk/uima-ducc-container/src/main/java/org/apache/uima/ducc/container/jd/wi/perf/WorkItemPerformanceIndividualKeeper.java
uima/sandbox/uima-ducc/trunk/uima-ducc-container/src/main/java/org/apache/uima/ducc/container/jd/wi/perf/WorkItemPerformanceSummaryKeeper.java
Modified:
uima/sandbox/uima-ducc/trunk/uima-ducc-container/src/main/java/org/apache/uima/ducc/container/jd/fsm/wi/ActionEnd.java
URL:
http://svn.apache.org/viewvc/uima/sandbox/uima-ducc/trunk/uima-ducc-container/src/main/java/org/apache/uima/ducc/container/jd/fsm/wi/ActionEnd.java?rev=1746716&r1=1746715&r2=1746716&view=diff
==============================================================================
---
uima/sandbox/uima-ducc/trunk/uima-ducc-container/src/main/java/org/apache/uima/ducc/container/jd/fsm/wi/ActionEnd.java
(original)
+++
uima/sandbox/uima-ducc/trunk/uima-ducc-container/src/main/java/org/apache/uima/ducc/container/jd/fsm/wi/ActionEnd.java
Fri Jun 3 13:30:39 2016
@@ -132,8 +132,8 @@ public class ActionEnd extends ActionEnd
size = list.size();
JobDriver jd =
JobDriver.getInstance();
String logdir =
jd.getLogDir();
- String wiNo =
""+wi.getSeqNo();
-
IWorkItemPerformanceIndividualKeeper wipik = new
WorkItemPerformanceIndividualKeeper(logdir, wiNo);
+ String seqNo =
""+wi.getSeqNo();
+
IWorkItemPerformanceIndividualKeeper wipik = new
WorkItemPerformanceIndividualKeeper(logdir, seqNo);
IWorkItemPerformanceSummaryKeeper wipsk =
jd.getWorkItemPerformanceSummaryKeeper();
wipsk.count();
long total_time = 0;
@@ -148,6 +148,10 @@ public class ActionEnd extends ActionEnd
catch(Exception
e) {
logger.error(location, ILogger.null_id, e);
}
+ if(time < 0) {
+ String
text = "seqNo="+seqNo+" "+"time="+time+" "+"analysisTime="+analysisTime+"
"+"uniqueName="+uniqueName;
+
logger.warn(location, ILogger.null_id, text);
+ }
wipik.dataAdd(name, uniqueName, time);
wipsk.dataAdd(name, uniqueName, time);
for(Entry<Object, Object> entry : properties.entrySet()) {
Modified:
uima/sandbox/uima-ducc/trunk/uima-ducc-container/src/main/java/org/apache/uima/ducc/container/jd/wi/perf/WorkItemPerformanceIndividualKeeper.java
URL:
http://svn.apache.org/viewvc/uima/sandbox/uima-ducc/trunk/uima-ducc-container/src/main/java/org/apache/uima/ducc/container/jd/wi/perf/WorkItemPerformanceIndividualKeeper.java?rev=1746716&r1=1746715&r2=1746716&view=diff
==============================================================================
---
uima/sandbox/uima-ducc/trunk/uima-ducc-container/src/main/java/org/apache/uima/ducc/container/jd/wi/perf/WorkItemPerformanceIndividualKeeper.java
(original)
+++
uima/sandbox/uima-ducc/trunk/uima-ducc-container/src/main/java/org/apache/uima/ducc/container/jd/wi/perf/WorkItemPerformanceIndividualKeeper.java
Fri Jun 3 13:30:39 2016
@@ -108,7 +108,12 @@ public class WorkItemPerformanceIndividu
MessageBuffer mb = new MessageBuffer();
mb.append(Standardize.Label.name.get()+name);
mb.append(Standardize.Label.sum.get()+timeSum);
- logger.debug(location, ILogger.null_id,
mb.toString());
+ if(lTimeSum < 0) {
+ logger.warn(location, ILogger.null_id,
mb.toString());
+ }
+ else {
+ logger.debug(location, ILogger.null_id,
mb.toString());
+ }
}
catch(Exception e) {
logger.error(location, ILogger.null_id, e);
Modified:
uima/sandbox/uima-ducc/trunk/uima-ducc-container/src/main/java/org/apache/uima/ducc/container/jd/wi/perf/WorkItemPerformanceSummaryKeeper.java
URL:
http://svn.apache.org/viewvc/uima/sandbox/uima-ducc/trunk/uima-ducc-container/src/main/java/org/apache/uima/ducc/container/jd/wi/perf/WorkItemPerformanceSummaryKeeper.java?rev=1746716&r1=1746715&r2=1746716&view=diff
==============================================================================
---
uima/sandbox/uima-ducc/trunk/uima-ducc-container/src/main/java/org/apache/uima/ducc/container/jd/wi/perf/WorkItemPerformanceSummaryKeeper.java
(original)
+++
uima/sandbox/uima-ducc/trunk/uima-ducc-container/src/main/java/org/apache/uima/ducc/container/jd/wi/perf/WorkItemPerformanceSummaryKeeper.java
Fri Jun 3 13:30:39 2016
@@ -127,7 +127,12 @@ public class WorkItemPerformanceSummaryK
mb.append(Standardize.Label.max.get()+timeMax);
mb.append(Standardize.Label.count.get()+count.get());
mb.append(Standardize.Label.total.get()+total.get());
- logger.debug(location, ILogger.null_id, mb.toString());
+ if((lTimeSum < 0)||(lTimeAvg < 0)||(lTimeMin <
0)||(lTimeMax < 0)) {
+ logger.warn(location, ILogger.null_id,
mb.toString());
+ }
+ else {
+ logger.debug(location, ILogger.null_id,
mb.toString());
+ }
}
catch(Exception e) {
logger.error(location, ILogger.null_id, e);
