svn commit: r1750413 - /uima/uima-ducc/trunk/uima-ducc-orchestrator/src/main/java/org/apache/uima/ducc/orchestrator/ProcessAccounting.java

[degenaro]

Author: degenaro
Date: Mon Jun 27 21:41:48 2016
New Revision: 1750413

URL: http://svn.apache.org/viewvc?rev=1750413&view=rev
Log:
UIMA-4989 Fix problems found by FindBugs

Modified:
    
uima/uima-ducc/trunk/uima-ducc-orchestrator/src/main/java/org/apache/uima/ducc/orchestrator/ProcessAccounting.java

Modified: 
uima/uima-ducc/trunk/uima-ducc-orchestrator/src/main/java/org/apache/uima/ducc/orchestrator/ProcessAccounting.java
URL: 
http://svn.apache.org/viewvc/uima/uima-ducc/trunk/uima-ducc-orchestrator/src/main/java/org/apache/uima/ducc/orchestrator/ProcessAccounting.java?rev=1750413&r1=1750412&r2=1750413&view=diff
==============================================================================
--- 
uima/uima-ducc/trunk/uima-ducc-orchestrator/src/main/java/org/apache/uima/ducc/orchestrator/ProcessAccounting.java
 (original)
+++ 
uima/uima-ducc/trunk/uima-ducc-orchestrator/src/main/java/org/apache/uima/ducc/orchestrator/ProcessAccounting.java
 Mon Jun 27 21:41:48 2016
@@ -105,16 +105,14 @@ public class ProcessAccounting {
                logger.trace(methodName, null, messages.fetch("enter"));
                boolean retVal = false;
                TrackSync ts = TrackSync.await(workMap, this.getClass(), 
methodName);
-               synchronized(workMap) {
-                       ts.using();
-                       if(!processToJobMap.containsKey(processId)) {
-                               processToJobMap.put(processId, jobId);
-                               retVal = true;
-                               logger.info(methodName, jobId, processId, 
messages.fetch("added"));
-                       }
-                       else {
-                               logger.warn(methodName, jobId, processId, 
messages.fetch("exists"));
-                       }
+               ts.using();
+               DuccId key = processToJobMap.put(processId, jobId);
+               if(key == null) {
+                       retVal = true;
+                       logger.info(methodName, jobId, processId, 
messages.fetch("added"));
+               }
+               else {
+                       logger.warn(methodName, jobId, processId, 
messages.fetch("exists"));
                }
                ts.ended();
                logger.trace(methodName, null, messages.fetch("exit"));