svn commit: r1750666 - /uima/uima-ducc/trunk/uima-ducc-sm/src/main/java/org/apache/uima/ducc/sm/PingDriver.java

[eae]

Author: eae
Date: Wed Jun 29 15:41:57 2016
New Revision: 1750666

URL: http://svn.apache.org/viewvc?rev=1750666&view=rev
Log:
UIMA-4995 always allow a service pinger to delete last instance

Modified:
    
uima/uima-ducc/trunk/uima-ducc-sm/src/main/java/org/apache/uima/ducc/sm/PingDriver.java

Modified: 
uima/uima-ducc/trunk/uima-ducc-sm/src/main/java/org/apache/uima/ducc/sm/PingDriver.java
URL: 
http://svn.apache.org/viewvc/uima/uima-ducc/trunk/uima-ducc-sm/src/main/java/org/apache/uima/ducc/sm/PingDriver.java?rev=1750666&r1=1750665&r2=1750666&view=diff
==============================================================================
--- 
uima/uima-ducc/trunk/uima-ducc-sm/src/main/java/org/apache/uima/ducc/sm/PingDriver.java
 (original)
+++ 
uima/uima-ducc/trunk/uima-ducc-sm/src/main/java/org/apache/uima/ducc/sm/PingDriver.java
 Wed Jun 29 15:41:57 2016
@@ -409,14 +409,15 @@ class PingDriver
 //                    logger.warn(methodName, sset.getId(), "Service shrink 
value capped by registered min of", reg_instances, "at", ndeletions);
 //                }            
 //            }
-            int refs = sset.countReferences();
-            int impls = sset.countImplementors();
-            if ( (impls <= ndeletions) && (refs > 0) ) {
-                ndeletions = Math.max(0, impls - 1);
-                logger.warn(methodName, sset.getId(), "Service shrink value 
capped at", ndeletions, "because there are still", refs, "references.");
-            }
+//            int refs = sset.countReferences();
+//            int impls = sset.countImplementors();
+//            if ( (impls <= ndeletions) && (refs > 0) ) {
+//                ndeletions = Math.max(0, impls - 1);
+//                logger.warn(methodName, sset.getId(), "Service shrink value 
capped at", ndeletions, "because there are still", refs, "references.");
+//            }
         }
 
+        //TODO safe against invalid or repeated deletion IDs?
         sset.signalRebalance(additions, deletions, ndeletions, 
response.isExcessiveFailures());
     }