[incubator-uniffle] branch master updated: [Minor] Cleanup "throws RuntimeException" (#549)

[ckj]

This is an automated email from the ASF dual-hosted git repository.

ckj pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-uniffle.git


The following commit(s) were added to refs/heads/master by this push:
     new 07aaeb26 [Minor] Cleanup "throws RuntimeException" (#549)
07aaeb26 is described below

commit 07aaeb26b80df471eccb42a9bb71b47c58961d6c
Author: Kaijie Chen <c...@apache.org>
AuthorDate: Fri Feb 3 18:51:18 2023 +0800

    [Minor] Cleanup "throws RuntimeException" (#549)
    
    ### What changes were proposed in this pull request?
    
    Remove "throws RuntimeException" from method signature.
    
    ### Why are the changes needed?
    
    There is no need to declare "throws RuntimeException".
    
    ### Does this PR introduce _any_ user-facing change?
    
    No.
    
    ### How was this patch tested?
    
    CI.
---
 .../src/main/java/org/apache/spark/shuffle/RssSparkShuffleUtils.java   | 2 +-
 .../main/java/org/apache/spark/shuffle/writer/RssShuffleWriter.java    | 2 +-
 .../main/java/org/apache/spark/shuffle/writer/RssShuffleWriter.java    | 2 +-
 common/src/main/java/org/apache/uniffle/common/util/RssUtils.java      | 3 +--
 .../src/main/java/org/apache/uniffle/coordinator/AccessManager.java    | 2 +-
 5 files changed, 5 insertions(+), 6 deletions(-)

diff --git 
a/client-spark/common/src/main/java/org/apache/spark/shuffle/RssSparkShuffleUtils.java
 
b/client-spark/common/src/main/java/org/apache/spark/shuffle/RssSparkShuffleUtils.java
index 358b0ae1..d7d68330 100644
--- 
a/client-spark/common/src/main/java/org/apache/spark/shuffle/RssSparkShuffleUtils.java
+++ 
b/client-spark/common/src/main/java/org/apache/spark/shuffle/RssSparkShuffleUtils.java
@@ -76,7 +76,7 @@ public class RssSparkShuffleUtils {
     return instance;
   }
 
-  public static List<CoordinatorClient> createCoordinatorClients(SparkConf 
sparkConf) throws RuntimeException {
+  public static List<CoordinatorClient> createCoordinatorClients(SparkConf 
sparkConf) {
     String clientType = sparkConf.get(RssSparkConfig.RSS_CLIENT_TYPE);
     String coordinators = sparkConf.get(RssSparkConfig.RSS_COORDINATOR_QUORUM);
     CoordinatorClientFactory coordinatorClientFactory = new 
CoordinatorClientFactory(ClientType.valueOf(clientType));
diff --git 
a/client-spark/spark2/src/main/java/org/apache/spark/shuffle/writer/RssShuffleWriter.java
 
b/client-spark/spark2/src/main/java/org/apache/spark/shuffle/writer/RssShuffleWriter.java
index 34deb77a..0def3b68 100644
--- 
a/client-spark/spark2/src/main/java/org/apache/spark/shuffle/writer/RssShuffleWriter.java
+++ 
b/client-spark/spark2/src/main/java/org/apache/spark/shuffle/writer/RssShuffleWriter.java
@@ -285,7 +285,7 @@ public class RssShuffleWriter<K, V, C> extends 
ShuffleWriter<K, V> {
   }
 
   @VisibleForTesting
-  protected void checkBlockSendResult(Set<Long> blockIds) throws 
RuntimeException {
+  protected void checkBlockSendResult(Set<Long> blockIds) {
     long start = System.currentTimeMillis();
     while (true) {
       Set<Long> failedBlockIds = shuffleManager.getFailedBlockIds(taskId);
diff --git 
a/client-spark/spark3/src/main/java/org/apache/spark/shuffle/writer/RssShuffleWriter.java
 
b/client-spark/spark3/src/main/java/org/apache/spark/shuffle/writer/RssShuffleWriter.java
index 21cb50db..79bba0c5 100644
--- 
a/client-spark/spark3/src/main/java/org/apache/spark/shuffle/writer/RssShuffleWriter.java
+++ 
b/client-spark/spark3/src/main/java/org/apache/spark/shuffle/writer/RssShuffleWriter.java
@@ -255,7 +255,7 @@ public class RssShuffleWriter<K, V, C> extends 
ShuffleWriter<K, V> {
   }
 
   @VisibleForTesting
-  protected void checkBlockSendResult(Set<Long> blockIds) throws 
RuntimeException {
+  protected void checkBlockSendResult(Set<Long> blockIds) {
     long start = System.currentTimeMillis();
     while (true) {
       checkIfBlocksFailed();
diff --git a/common/src/main/java/org/apache/uniffle/common/util/RssUtils.java 
b/common/src/main/java/org/apache/uniffle/common/util/RssUtils.java
index a079753b..2e2c4394 100644
--- a/common/src/main/java/org/apache/uniffle/common/util/RssUtils.java
+++ b/common/src/main/java/org/apache/uniffle/common/util/RssUtils.java
@@ -187,8 +187,7 @@ public class RssUtils {
     return String.join(Constants.KEY_SPLIT_CHAR, appId, 
String.valueOf(shuffleId), String.valueOf(partition));
   }
 
-  public static <T> List<T> loadExtensions(
-      Class<T> extClass, List<String> classes, Object obj) throws 
RuntimeException {
+  public static <T> List<T> loadExtensions(Class<T> extClass, List<String> 
classes, Object obj) {
     if (classes == null || classes.isEmpty()) {
       throw new RuntimeException("Empty classes");
     }
diff --git 
a/coordinator/src/main/java/org/apache/uniffle/coordinator/AccessManager.java 
b/coordinator/src/main/java/org/apache/uniffle/coordinator/AccessManager.java
index 4c7b3665..ea5a6b21 100644
--- 
a/coordinator/src/main/java/org/apache/uniffle/coordinator/AccessManager.java
+++ 
b/coordinator/src/main/java/org/apache/uniffle/coordinator/AccessManager.java
@@ -55,7 +55,7 @@ public class AccessManager {
     init();
   }
 
-  private void init() throws RuntimeException {
+  private void init() {
     List<String> checkers = 
coordinatorConf.get(CoordinatorConf.COORDINATOR_ACCESS_CHECKERS);
     if (CollectionUtils.isEmpty(checkers)) {
       LOG.warn("Access checkers is empty, will not init any checkers.");