[incubator-uniffle] branch master updated: [#244][FOLLOWUP] test: CoordinatorGrpcTest.rpcMetricsTest. (#1251)

[roryqi]

This is an automated email from the ASF dual-hosted git repository.

roryqi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-uniffle.git


The following commit(s) were added to refs/heads/master by this push:
     new ecb7ff086 [#244][FOLLOWUP] test: CoordinatorGrpcTest.rpcMetricsTest. 
(#1251)
ecb7ff086 is described below

commit ecb7ff0868fa250c9952bd900bdab1be229b61f7
Author: zhengchenyu <zhengcheny...@163.com>
AuthorDate: Fri Oct 20 19:02:55 2023 +0800

    [#244][FOLLOWUP] test: CoordinatorGrpcTest.rpcMetricsTest. (#1251)
    
    ### What changes were proposed in this pull request?
    
    Fix test
    
    ### Why are the changes needed?
    
    Fix: #244
    
    ### Does this PR introduce _any_ user-facing change?
    
    
    No.
    
    ### How was this patch tested?
    
    unit test
---
 .../java/org/apache/uniffle/test/CoordinatorGrpcTest.java     | 11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)

diff --git 
a/integration-test/common/src/test/java/org/apache/uniffle/test/CoordinatorGrpcTest.java
 
b/integration-test/common/src/test/java/org/apache/uniffle/test/CoordinatorGrpcTest.java
index 88a04190f..8b0693a62 100644
--- 
a/integration-test/common/src/test/java/org/apache/uniffle/test/CoordinatorGrpcTest.java
+++ 
b/integration-test/common/src/test/java/org/apache/uniffle/test/CoordinatorGrpcTest.java
@@ -326,13 +326,6 @@ public class CoordinatorGrpcTest extends 
CoordinatorTestBase {
 
   @Test
   public void rpcMetricsTest() throws Exception {
-    double oldValue =
-        coordinators
-            .get(0)
-            .getGrpcMetrics()
-            .getCounterMap()
-            .get(CoordinatorGrpcMetrics.HEARTBEAT_METHOD)
-            .get();
     CoordinatorTestUtils.waitForRegister(coordinatorClient, 2);
     double newValue =
         coordinators
@@ -341,13 +334,13 @@ public class CoordinatorGrpcTest extends 
CoordinatorTestBase {
             .getCounterMap()
             .get(CoordinatorGrpcMetrics.HEARTBEAT_METHOD)
             .get();
-    assertTrue(newValue - oldValue > 1);
+    assertTrue(newValue > 1);
 
     String appId = "rpcMetricsTest";
     RssGetShuffleAssignmentsRequest request =
         new RssGetShuffleAssignmentsRequest(
             appId, 1, 10, 4, 1, 
Sets.newHashSet(Constants.SHUFFLE_SERVER_VERSION));
-    oldValue =
+    double oldValue =
         coordinators
             .get(0)
             .getGrpcMetrics()