(incubator-uniffle) branch master updated: [MINOR] fix: flaky test ShuffleTaskManagerTest#checkAndClearLeakShuffleDataTest (#1320)

[xianjingfeng]

This is an automated email from the ASF dual-hosted git repository.

xianjingfeng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-uniffle.git


The following commit(s) were added to refs/heads/master by this push:
     new e1a54999e [MINOR] fix: flaky test 
ShuffleTaskManagerTest#checkAndClearLeakShuffleDataTest (#1320)
e1a54999e is described below

commit e1a54999ec2edf280b73e20e76dfcf1d89278d00
Author: xianjingfeng <xianjingfeng...@gmail.com>
AuthorDate: Fri Nov 17 17:00:58 2023 +0800

    [MINOR] fix: flaky test 
ShuffleTaskManagerTest#checkAndClearLeakShuffleDataTest (#1320)
    
    ### What changes were proposed in this pull request?
    fix flaky test ShuffleTaskManagerTest#checkAndClearLeakShuffleDataTest.
    
    ### Why are the changes needed?
    ShuffleTaskManagerTest.checkAndClearLeakShuffleDataTest:940 expected:
    <false> but was: <true>
    
    The cause of the problem:
    Application in shuffleTaskInfos is removed first, and then remove the 
directory in the local disk.
    Refer: org.apache.uniffle.server.ShuffleTaskManager#removeResources
    
    ### Does this PR introduce any user-facing change?
    No.
    
    ### How was this patch tested?
    Repeat it for 100 times in my development enviroment.
---
 .../test/java/org/apache/uniffle/server/ShuffleTaskManagerTest.java  | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git 
a/server/src/test/java/org/apache/uniffle/server/ShuffleTaskManagerTest.java 
b/server/src/test/java/org/apache/uniffle/server/ShuffleTaskManagerTest.java
index 389b13650..6758ec834 100644
--- a/server/src/test/java/org/apache/uniffle/server/ShuffleTaskManagerTest.java
+++ b/server/src/test/java/org/apache/uniffle/server/ShuffleTaskManagerTest.java
@@ -937,8 +937,9 @@ public class ShuffleTaskManagerTest extends HadoopTestBase {
     File hiddenFile = new File(storageDir + "/" + 
LocalStorageChecker.CHECKER_DIR_NAME);
     hiddenFile.mkdir();
 
-    appIdsOnDisk = getAppIdsOnDisk(localStorageManager);
-    assertFalse(appIdsOnDisk.contains(appId));
+    Awaitility.await()
+        .timeout(10, TimeUnit.SECONDS)
+        .until(() -> !getAppIdsOnDisk(localStorageManager).contains(appId));
     assertFalse(appIdsOnDisk.contains(LocalStorageChecker.CHECKER_DIR_NAME));
 
     // mock leak shuffle data