This is an automated email from the ASF dual-hosted git repository.
xianjingfeng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-uniffle.git
The following commit(s) were added to refs/heads/master by this push:
new 22c1cd023 [#1330] improvement: optimize tips for checking replica
settings (#1334)
22c1cd023 is described below
commit 22c1cd0239473c76addb44b7d993f340f3eaff5d
Author: guixiaowen <[email protected]>
AuthorDate: Wed Nov 29 11:35:36 2023 +0800
[#1330] improvement: optimize tips for checking replica settings (#1334)
### What changes were proposed in this pull request?
The tips for checking replica settings is a bit unclear.
### Why are the changes needed?
This tip may be misleading
### Does this PR introduce any user-facing change?
No
### How was this patch tested?
No need
---
common/src/main/java/org/apache/uniffle/common/util/RssUtils.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/src/main/java/org/apache/uniffle/common/util/RssUtils.java
b/common/src/main/java/org/apache/uniffle/common/util/RssUtils.java
index 8a117fd18..601f809e3 100644
--- a/common/src/main/java/org/apache/uniffle/common/util/RssUtils.java
+++ b/common/src/main/java/org/apache/uniffle/common/util/RssUtils.java
@@ -310,7 +310,7 @@ public class RssUtils {
public static void checkQuorumSetting(int replica, int replicaWrite, int
replicaRead) {
if (replica < 1 || replicaWrite > replica || replicaRead > replica) {
throw new RssException(
- "Replica config is invalid, recommend replica.write + replica.read >
replica");
+ "Replica config is invalid, it cannot be less than 1 or less than
replica.write or less than replica.read. Please check it.");
}
if (replicaWrite + replicaRead <= replica) {
throw new RssException(