This is an automated email from the ASF dual-hosted git repository.

zuston pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-uniffle.git


The following commit(s) were added to refs/heads/master by this push:
     new c5be58ffe [MINOR] chore(client): Specify name for data transfer thread 
pool (#1353)
c5be58ffe is described below

commit c5be58ffe04d51aa68329a5e2a0a5bae7e0fa32e
Author: Zhen Wang <[email protected]>
AuthorDate: Thu Dec 7 15:08:57 2023 +0800

    [MINOR] chore(client): Specify name for data transfer thread pool (#1353)
    
    ### What changes were proposed in this pull request?
    
    Specify name for dataTransferPool
    
    ### Why are the changes needed?
    
    `dataTransferPool` thread pool did not specify name.
    
    
![image](https://github.com/apache/incubator-uniffle/assets/17894939/3baca266-f95b-4af0-a613-a2aa582c8e2b)
    
    ### Does this PR introduce _any_ user-facing change?
    
    No.
    
    ### How was this patch tested?
    
    minor fix
---
 .../java/org/apache/uniffle/client/impl/ShuffleWriteClientImpl.java  | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git 
a/client/src/main/java/org/apache/uniffle/client/impl/ShuffleWriteClientImpl.java
 
b/client/src/main/java/org/apache/uniffle/client/impl/ShuffleWriteClientImpl.java
index ff7aad719..4f01c6de6 100644
--- 
a/client/src/main/java/org/apache/uniffle/client/impl/ShuffleWriteClientImpl.java
+++ 
b/client/src/main/java/org/apache/uniffle/client/impl/ShuffleWriteClientImpl.java
@@ -27,7 +27,6 @@ import java.util.concurrent.BlockingQueue;
 import java.util.concurrent.Callable;
 import java.util.concurrent.CompletableFuture;
 import java.util.concurrent.ExecutorService;
-import java.util.concurrent.Executors;
 import java.util.concurrent.ForkJoinPool;
 import java.util.concurrent.Future;
 import java.util.concurrent.LinkedBlockingQueue;
@@ -139,7 +138,9 @@ public class ShuffleWriteClientImpl implements 
ShuffleWriteClient {
     this.replicaWrite = builder.getReplicaWrite();
     this.replicaRead = builder.getReplicaRead();
     this.replicaSkipEnabled = builder.isReplicaSkipEnabled();
-    this.dataTransferPool = 
Executors.newFixedThreadPool(builder.getDataTransferPoolSize());
+    this.dataTransferPool =
+        ThreadUtils.getDaemonFixedThreadPool(
+            builder.getDataTransferPoolSize(), "client-data-transfer");
     this.dataCommitPoolSize = builder.getDataCommitPoolSize();
     this.unregisterThreadPoolSize = builder.getUnregisterThreadPoolSize();
     this.unregisterRequestTimeSec = builder.getUnregisterRequestTimeSec();

Reply via email to