This is an automated email from the ASF dual-hosted git repository.
smallzhongfeng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-uniffle.git
The following commit(s) were added to refs/heads/master by this push:
new cc5a038b4 [#1267][FOLLOWUP] improvement(client): INFO log level should
be used in RetryUtils (#1500)
cc5a038b4 is described below
commit cc5a038b457ba04dba77e538a523bd9677641c4d
Author: RickyMa <[email protected]>
AuthorDate: Tue Feb 6 14:21:12 2024 +0800
[#1267][FOLLOWUP] improvement(client): INFO log level should be used in
RetryUtils (#1500)
### What changes were proposed in this pull request?
INFO log level should be used in RetryUtils. Because these log messages are
not actual errors.
### Why are the changes needed?
It's a followup PR for
[#1411](https://github.com/apache/incubator-uniffle/pull/1411).
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Existing UTs.
---
.../src/main/java/org/apache/uniffle/common/util/RetryUtils.java | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git
a/common/src/main/java/org/apache/uniffle/common/util/RetryUtils.java
b/common/src/main/java/org/apache/uniffle/common/util/RetryUtils.java
index 961fb4fcf..4a159858e 100644
--- a/common/src/main/java/org/apache/uniffle/common/util/RetryUtils.java
+++ b/common/src/main/java/org/apache/uniffle/common/util/RetryUtils.java
@@ -83,14 +83,14 @@ public class RetryUtils {
retry++;
if (isRetryFunc.apply(t) && retry < retryTimes) {
if (LOG.isDebugEnabled()) {
- LOG.error("Retry due to Throwable ", t);
+ LOG.debug("Retry due to: ", t);
} else {
- LOG.error(
- "Retry due to Throwable {}. Use DEBUG level to see the full
stack: {}",
+ LOG.info(
+ "Retry due to: {}. Use DEBUG level to see the full stack: {}",
t.getClass().getName(),
t.getMessage());
}
- LOG.error(
+ LOG.info(
"Will retry {} more time(s) after waiting {} milliseconds.",
retryTimes - retry,
intervalMs);
